Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tools test #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add tools test #9

wants to merge 1 commit into from

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Apr 11, 2023

No description provided.

@TedBrookings TedBrookings self-assigned this Apr 14, 2023
TedBrookings
TedBrookings approved these changes Apr 14, 2023
View reviewed changes
Copy link

@TedBrookings TedBrookings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change for path to precommit.sh. Otherwise looks good (it's the same stuff I looked at that you added recently).

README.md
- Run the precommit script (unit tests, linting, code-style, type checking)

```bash
bash scripts/precommit.sh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bash scripts/precommit.sh
bash ci/precommit.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TedBrookings TedBrookings TedBrookings approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@TedBrookings TedBrookings

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nh13 @TedBrookings